Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OR-5240 Built-In publisher Just #59

Merged
merged 3 commits into from
Mar 28, 2023
Merged

OR-5240 Built-In publisher Just #59

merged 3 commits into from
Mar 28, 2023

Conversation

crazymanish
Copy link
Owner

@crazymanish crazymanish commented Mar 27, 2023 •
edited
Loading

Context

In this PR

Testing steps

  • Git checkout this pr git-branch
  • Open the project and cmd+u

Demo

Screenshot 2023-03-27 at 21 06 43

@crazymanish crazymanish added this to the Publisher milestone Mar 27, 2023
@crazymanish crazymanish requested review from buh and raihan March 27, 2023 19:10
@crazymanish crazymanish linked an issue Mar 27, 2023 that may be closed by this pull request
[w13(26march-1april)] Publisher: Built-in publishers #3
Closed
buh
buh approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@buh buh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please fix my comment

CombineDemo/CombineDemoTests/Publishers/BuiltInPublishers/JustTests.swift Outdated
Comment on lines 24 to 25
subject.cancellables.forEach { $0.cancel() }
subject.cancellables.removeAll()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no need to do.
The concept of cancellables is about if it deallocated it will cancel all subscriptions which it contains

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know! thank you

@crazymanish crazymanish merged commit ec50dec into main Mar 28, 2023
@crazymanish crazymanish deleted the OR-5240-p1 branch March 28, 2023 18:00
crazymanish added a commit that referenced this pull request Mar 28, 2023
@crazymanish
Merge branch 'main' into OR-5240-p1
86a561c 
* main:
  OR-5240 Built-In publisher `Just` (#59)
crazymanish added a commit that referenced this pull request Mar 28, 2023
@crazymanish
Merge branch 'OR-5240-p1' into OR-5240-p2
d00d23d 
* OR-5240-p1:
  OR-5240 Built-In publisher `Just` (#59)
  OR-5240 PR review fix
@crazymanish crazymanish mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buh buh buh approved these changes

@raihan raihan Awaiting requested review from raihan

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Combine
Status: Done
Milestone
Publisher
Development

Successfully merging this pull request may close these issues.

[w13(26march-1april)] Publisher: Built-in publishers
2 participants
@crazymanish @buh