From 9181e18a5b0e075be62fcb92adb49750d550290d Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Wed, 2 Aug 2017 18:50:21 +0200 Subject: [PATCH 1/7] Remove depreciated createJSModules --- .../com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index d19c3b56..3e187beb 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -19,11 +19,6 @@ */ public class SplashScreenReactPackage implements ReactPackage { - @Override - public List> createJSModules() { - return Collections.emptyList(); - } - @Override public List createViewManagers(ReactApplicationContext reactContext) { return Collections.emptyList(); @@ -36,4 +31,4 @@ public List createNativeModules( modules.add(new SplashScreenModule(reactContext)); return modules; } -} \ No newline at end of file +} From df2f4a220aa80d3d05c5700206c593468a9ebfa2 Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Wed, 2 Aug 2017 19:05:27 +0200 Subject: [PATCH 2/7] Remove only @Override marker --- .../com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index 3e187beb..2e1ce5a7 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -18,6 +18,10 @@ * Email:crazycodeboy@gmail.com */ public class SplashScreenReactPackage implements ReactPackage { + + public List> createJSModules() { + return Collections.emptyList(); + } @Override public List createViewManagers(ReactApplicationContext reactContext) { From 9be7aeef27771bd6f6f2d3ca805ce6ac24eb7e3c Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Wed, 2 Aug 2017 19:43:19 +0200 Subject: [PATCH 3/7] Added comment --- .../java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 1 + 1 file changed, 1 insertion(+) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index 2e1ce5a7..1df6c12f 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -19,6 +19,7 @@ */ public class SplashScreenReactPackage implements ReactPackage { + // Deprecated RN 0.47 public List> createJSModules() { return Collections.emptyList(); } From 8d21df1a6fce81b65014da7e8a46d5a707cda181 Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Wed, 2 Aug 2017 19:50:35 +0200 Subject: [PATCH 4/7] Remove trailing spaces --- .../java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index 1df6c12f..5aa4eae1 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -18,7 +18,7 @@ * Email:crazycodeboy@gmail.com */ public class SplashScreenReactPackage implements ReactPackage { - + // Deprecated RN 0.47 public List> createJSModules() { return Collections.emptyList(); From 5ad38032c285f718cdf4de057c56f3886c3f5b3c Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Wed, 2 Aug 2017 19:50:55 +0200 Subject: [PATCH 5/7] Remove trailing spaces --- .../com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index 5aa4eae1..5cb662f8 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -20,8 +20,8 @@ public class SplashScreenReactPackage implements ReactPackage { // Deprecated RN 0.47 - public List> createJSModules() { - return Collections.emptyList(); + public List> createJSModules() { + return Collections.emptyList(); } @Override From 1a2d53ae5904f54fdf3cb0824d364bb65fb21639 Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Wed, 2 Aug 2017 23:39:02 +0200 Subject: [PATCH 6/7] Fix typo in comment --- .../java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index 5cb662f8..de3882f4 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -19,7 +19,7 @@ */ public class SplashScreenReactPackage implements ReactPackage { - // Deprecated RN 0.47 + // Depreciated RN 0.47 public List> createJSModules() { return Collections.emptyList(); } From 50adfdd9fec13d14a739425d002f0d5a06e86eca Mon Sep 17 00:00:00 2001 From: Radek Czemerys Date: Mon, 7 Aug 2017 14:10:12 +0200 Subject: [PATCH 7/7] Fix typo in comment --- .../java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java index de3882f4..5cb662f8 100644 --- a/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java +++ b/android/src/main/java/com/cboy/rn/splashscreen/SplashScreenReactPackage.java @@ -19,7 +19,7 @@ */ public class SplashScreenReactPackage implements ReactPackage { - // Depreciated RN 0.47 + // Deprecated RN 0.47 public List> createJSModules() { return Collections.emptyList(); }