Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop checking the configuration file #860

Closed
szepeviktor opened this issue Oct 23, 2023 · 3 comments
Closed

Stop checking the configuration file #860

szepeviktor opened this issue Oct 23, 2023 · 3 comments

Comments

@szepeviktor
Copy link
Contributor

typos -c ./.github/workflows/typo_config.toml

Usually config files are full of typos.
Please consider ignoring specified config files.
@szepeviktor szepeviktor changed the title Stop checking configuration file Stop checking the configuration file Oct 23, 2023
@epage
Copy link
Collaborator

epage commented Oct 23, 2023 •
edited
Loading

#711 had this for auto-discovered configs which was fixed in #762. We did this all by checkin for the built-in file names. We are not checking for the actual active config file name

@epage
Copy link
Collaborator

epage commented Oct 23, 2023

Should we bother fixing this or just have people name their --config file to be one of the built-in names?

@szepeviktor
Copy link
Contributor Author

to be one of the built-in names?

I second this.

@szepeviktor szepeviktor closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @szepeviktor