Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Orders -> Export -> Line items crashes #3592

Closed
SayChi opened this issue Jul 18, 2024 · 3 comments
Closed

[5.x]: Orders -> Export -> Line items crashes #3592

SayChi opened this issue Jul 18, 2024 · 3 comments

Comments

@SayChi
Copy link

SayChi commented Jul 18, 2024

What happened?

Description

Using the line items export on admin/commerce/orders crashes

Pretty sure all that's needed is to change this line:
https://github.com/craftcms/commerce/blob/5.x/src/exports/LineItemExport.php#L48

Should be promotionalAmount instead of saleAmount

Steps to reproduce

  1. Go to admin/commerce/orders
  2. Export
  3. Export type: Line items
  4. Executing throws

Expected behavior

No crash

Actual behavior

Yes crash

Craft CMS version

Craft Pro 5.2.4.1

Craft Commerce version

5.0.11.1

PHP version

8.2.21

Operating system and version

Linux 3.10.0-1160.92.1.el7.x86_64

Database type and version

MariaDB 10.3.27

Image driver and version

GD 8.2.21

Installed plugins and versions

  • Amazon SES 3.1.0
  • CKEditor 4.1.0
  • Cloner 3.0.0
  • Comments 3.0.0
  • Contact Form 3.1.0
  • Craft Commerce 5.0.11.1
  • DigitalOcean Spaces Filesystem 3.0.0-beta.1
  • Maps 5.0.1
  • Mollie for Craft Commerce 4.2.0
  • Navigation 3.0.1
  • reCAPTCHA v3 for Craft CMS 3.0.1
  • SEO v5.0.0-rc4
  • Sprig 3.0.2
Copy link

linear bot commented Jul 18, 2024

@lukeholder
Copy link
Member

lukeholder commented Jul 19, 2024

Thanks for reporting this. It is fixed for the next release.

To get the fix early, change your craftcms/commerce requirement in composer.json to:

"require": {
  "craftcms/commerce": "5.x-dev#b54a84ea6a3bd6b4711bfd648a58efa739bf34a9 as 5.0.13",
  "...": "..."
}

Then run composer update.

We will update this ticket once the release it out.

@nfourtythree
Copy link
Contributor

Hi

Commerce 5.0.14 has now been released with this fix included.

Please update your project to get the latest version.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants