Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x]: UI bug: Tabs not switching via dropdown in the "Promotions" settings #3162

Closed
Romanavr opened this issue May 3, 2023 · 2 comments
Closed
Assignees
Labels
bug commerce4 Issues related to Commerce v4 🖥 UI

Comments

@Romanavr
Copy link
Contributor

Romanavr commented May 3, 2023

What happened?

Description

изображение
It's not possible on the small screens, in the "Promotions" settings(in the CP) switch tabs via dropdown.
Was able reproduce it only for the "Promotions" section on a few different sites with the different commerce 4.x versions.

Steps to reproduce

  1. Go to, for example, Sales settings -> site.com/admin-url/commerce/promotions/sales/new
  2. Reduce window size and try to switch tabs using dropdown.

Expected behavior

It should switch tabs I guess

Actual behavior

This does not work and throws error in the console: Uncaught Invalid tab ID
изображение

Craft CMS version

4.4.6.1

Craft Commerce version

4.2.6

PHP version

8.1

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@Romanavr Romanavr added commerce4 Issues related to Commerce v4 bug labels May 3, 2023
@Romanavr Romanavr changed the title [4.x]: UI bug: Tabs not switching via the dropdown in the "Promotions" settings [4.x]: UI bug: Tabs not switching via dropdown in the "Promotions" settings May 3, 2023
@pdaleramirez pdaleramirez removed the 🔎 status: investigating Trying to reproduce label May 5, 2023
@pdaleramirez
Copy link
Contributor

@Romanavr Thank you for reporting. I was able to replicate this issue and added a PR fix for this here #3166

We’ll add the fix on the next release.

@pdaleramirez pdaleramirez self-assigned this May 5, 2023
@lukeholder
Copy link
Member

This was fixed in Commerce 4.2.9. Thanks for reporting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug commerce4 Issues related to Commerce v4 🖥 UI
Projects
None yet
Development

No branches or pull requests

3 participants