Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octave number in note_number_to_name and note_name_to_number is off by 1 #91

Closed
craffel opened this issue Sep 7, 2016 · 0 comments
Closed

Octave number in note_number_to_name and note_name_to_number is off by 1 #91

craffel opened this issue Sep 7, 2016 · 0 comments

Comments

@craffel
Copy link
Owner

craffel commented Sep 7, 2016

As reported in librosa/librosa#197 (the reference implementation for these functions in pretty_midi), note-name-to-number and vice-versa conversion has an octave-off-by-one error.
@craffel craffel closed this as completed in 606f9da Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craffel