Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length to get the entire duration of midi, similar to get_end_time #203

Closed
jonata opened this issue Aug 9, 2021 · 2 comments
Closed

Comments

@jonata
Copy link

jonata commented Aug 9, 2021

Hi!

I see some discussion on #80. I see that get_end_time does not give me the duration of the midi file in some cases. For a reference, if you look at mido length property, it would calculate all messages' times to get the desired duration value. What about adding this length property just like mido does?

Thanks!

@craffel
Copy link
Owner

craffel commented Aug 9, 2021

The get_end_time does exactly that - it provides the time of the final event (across all event types). The issue you linked was proposing that get_end_time only operate on note events.

@craffel craffel closed this as completed Aug 9, 2021
@jonata
Copy link
Author

jonata commented Aug 9, 2021

Sorry, but in my tests I am getting different results using get_end_time and mido's length. So get_end_time does not do "exactly that". It seems that it does not get "all event types".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants