From 6f34354ed644d3246f42af2fd956a8adaace125e Mon Sep 17 00:00:00 2001
From: Jacques Raphanel <jraphanel@free.fr>
Date: Mon, 30 Oct 2023 13:36:29 +0100
Subject: [PATCH] chore(ci): improve release workflow

---
 .github/workflows/release.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 9bb53bb..39c4b3f 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -46,18 +46,19 @@ jobs:
         force: ${{ needs.inputs.outputs.force_arg }}
 
     - uses: actions/upload-artifact@v3
+      if: steps.release.outputs.released == 'true'
       with:
         name: linux-build
         path: ./installer/dist/*.tar.gz
 
     - uses: actions/upload-artifact@v3
+      if: steps.release.outputs.released == 'true'
       with:
         name: python-build
         path: ./dist/*
 
     - name: Publish package to PyPI
       uses: pypa/gh-action-pypi-publish@release/v1
-      continue-on-error: true
       if: steps.release.outputs.released == 'true'
       with:
         skip-existing: true
@@ -68,7 +69,7 @@ jobs:
       needs: [release]
       runs-on: windows-latest
       concurrency: windows-build
-      if: github.repository == 'crabisoft/pdbstore' && ${{ needs.release.outputs.released == 'true' }}
+      if: github.repository == 'crabisoft/pdbstore' && needs.release.outputs.released == 'true'
       steps:
         - uses: actions/checkout@v4.1.0
           with:
@@ -88,7 +89,7 @@ jobs:
             path: ./installer/dist/*.zip
 
   release-notes:
-      if: github.repository == 'crabisoft/pdbstore' && ${{ needs.release.outputs.released == 'true' }}
+      if: github.repository == 'crabisoft/pdbstore' && needs.release.outputs.released == 'true'
       needs: [release, windows-build]
       runs-on: ubuntu-latest
       concurrency: publish