Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$r5.apply should generate Bundle.entry.fullUrl and references should be updated to use those fulUrl entires for resolution #583

Open
rdingwell opened this issue Nov 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rdingwell
Copy link

The following is contained in the specification wrt resolving references in a bundle: Several portions of this algorithm are dependent on on the presence of Bundle.entry.fullUrl. In instances where references might be resolved within a Bundle but entries do not have fullURLs, resolution expectations are undefined.

Currently, the $r5.apply operation produces a bundle with entries that do not have fullUrl attributes. There are also references between the resources contained in the resulting bundle, an example of which is contained below. These references are based solely off of the id of a resources within the Bundle.entry list. This places the resolution of these references outside of a mechanism defined in the specification which can result in errors between implementations that make use of the output of the operation. Adding fullUrl attributes to each of the Bundle.entry items and using references that point to those items would create Bundles that have a specification defined means of resolving references.

 "resource": {
         "reference": "ENACT-1-ACT-1"
  }
@JPercival
Copy link
Contributor

We'll need to add a configuration for the baseUrl as part of the Bundle generation. Currently, this library lives independently of any server and doesn't have any concept of a base server address, so it's up the application consuming this library to rewrite links as needed. The same is true for the next and prev links in the Bundle

@JPercival JPercival added the enhancement New feature or request label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants