Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA3 get_digest should be const #213

Closed
mborland opened this issue Jan 16, 2025 · 0 comments · Fixed by #216
Closed

SHA3 get_digest should be const #213

mborland opened this issue Jan 16, 2025 · 0 comments · Fixed by #216
Assignees
Labels
Bug Something isn't working

Comments

@mborland
Copy link
Member

We should be able to differentiate the XOF and non-xof paths like:

template <bool Const = !is_xof>
    [[nodiscard("Digest is the function return value")]] BOOST_CRYPT_GPU_ENABLED_CONSTEXPR
    compat::enable_if_t<Const, compat::expected<return_type, state>> get_digest() const noexcept;

This also allows the get_digest with amounts to only impact the XOF paths

@mborland mborland added the Bug Something isn't working label Jan 16, 2025
@mborland mborland self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant