From af72f50930691491be0e312b37adf68693e568ac Mon Sep 17 00:00:00 2001 From: Connor Ferguson <68167430+cpfergus1@users.noreply.github.com> Date: Tue, 25 May 2021 07:05:16 -0600 Subject: [PATCH] Replace update_attributes with update [#3334](https://github.com/solidusio/solidus/pull/3334) --- lib/solidus_expedited_exchanges/unreturned_item_charger.rb | 4 ++-- spec/order_extension_spec.rb | 4 ++-- spec/unreturned_item_charger_spec.rb | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/solidus_expedited_exchanges/unreturned_item_charger.rb b/lib/solidus_expedited_exchanges/unreturned_item_charger.rb index 3f2d47d..b703a56 100644 --- a/lib/solidus_expedited_exchanges/unreturned_item_charger.rb +++ b/lib/solidus_expedited_exchanges/unreturned_item_charger.rb @@ -71,13 +71,13 @@ def add_exchange_variants_to_order new_inventory_unit_attributes[:order_id] = new_order.id end - i.update_attributes!(new_inventory_unit_attributes) + i.update!(new_inventory_unit_attributes) end end end def set_shipment_for_new_order - @shipment.update_attributes!(order_id: new_order.id) + @shipment.update!(order_id: new_order.id) new_order.shipments.reset end diff --git a/spec/order_extension_spec.rb b/spec/order_extension_spec.rb index 5e1a0a1..32ca354 100644 --- a/spec/order_extension_spec.rb +++ b/spec/order_extension_spec.rb @@ -43,7 +43,7 @@ context "shipment created before order" do before do - order.shipments.first.update_attributes!(created_at: order.created_at - 1.day) + order.shipments.first.update!(created_at: order.created_at - 1.day) end it { is_expected.to be true } @@ -55,7 +55,7 @@ subject { described_class.unreturned_exchange } it 'includes orders that have a shipment created prior to the order' do - order.shipments.first.update_attributes!(created_at: order.created_at - 1.day) + order.shipments.first.update!(created_at: order.created_at - 1.day) expect(subject).to include order end diff --git a/spec/unreturned_item_charger_spec.rb b/spec/unreturned_item_charger_spec.rb index b645cd9..4baa52e 100644 --- a/spec/unreturned_item_charger_spec.rb +++ b/spec/unreturned_item_charger_spec.rb @@ -98,7 +98,7 @@ describe "#charge_for_items" do before do - original_variant.update_attributes!(track_inventory: true) + original_variant.update!(track_inventory: true) original_variant.stock_items.update_all(backorderable: false) end @@ -106,7 +106,7 @@ context "new order is not an unreturned exchange" do before do - allow_any_instance_of(Spree::Shipment).to receive(:update_attributes!) + allow_any_instance_of(Spree::Shipment).to receive(:update!) end it "raises an error" do