fix: Do not display Viewer's Download button on iOS Flagship app #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current `FooterContent` implementation does not handle gap between child items. So we used to add margin left or right on them based on usage Instead of doing this we prefer to handle gap between items directly in `FooterContent` so child items don't have to care about this This would allow to compose child items more easily without risk of having incorrect margins BREAKING CHANGE: Items inside of `FooterActionButtons` should not have specified margins anymore as those are now handled by its container. Remove them to avoid duplicate margins
Ldoppea
requested review from
JF-Cozy,
Merkur39 and
trollepierre
as code owners
Ldoppea
force-pushed
the
feat/disable_download_io_aa
branch
from
5638a5b to
5ed73d6
Compare
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 22, 2022
`cozy-ui` as been upgraded to to `71.0.0` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215
1 task
BundleMonUnchanged files (2)
No change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
trollepierre
approved these changes
Aug 23, 2022
Current implementation of iOS Flagship app doesn't handle files download correctly So we want to temporarily disable Download button on this platform This commit is meant to be reverted when files download is fixed on iOS Flagship app
Ldoppea
force-pushed
the
feat/disable_download_io_aa
branch
from
5ed73d6 to
8cfa363
Compare
|
🎉 This PR is included in version 72.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Aug 24, 2022
`cozy-ui` as been proactively upgraded to to `72.0.0` so we don't forget to apply breaking-changes from cozy/cozy-ui#2204 and cozy/cozy-ui#2215
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Aug 24, 2022
1 task
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Aug 24, 2022
`cozy-ui` as been proactively upgraded to to `72.0.0` so we don't forget to apply breaking-changes from cozy/cozy-ui#2204 and cozy/cozy-ui#2215 BREAKING CHANGE: cozy-ui >= 72.0.0 is now required
Ldoppea
added a commit
to cozy/cozy-libs
that referenced
this pull request
Aug 24, 2022
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 25, 2022
`cozy-ui` as been upgraded to to `71.0.0` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 25, 2022
`cozy-ui` as been upgraded to to `71.0.0` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215 This commit fixes the previous commit that wrongly set the version 7c6d187
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 25, 2022
`cozy-ui` as been upgraded to to `71.0.0` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215 This commit fixes the previous commit that wrongly set the version 7c6d187 Related PR: #2672
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 25, 2022
`cozy-ui` as been upgraded to to `72.0.0` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215 This commit fixes the previous commit that wrongly set the version 7c6d187 Related PR: #2672 feat: A
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 26, 2022
`cozy-ui` as been upgraded to to `73.0.1` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215 This commit fixes the previous commit that wrongly set the version 7c6d187 Related PR: #2672 feat: A feat: A
Ldoppea
added a commit
to cozy/cozy-drive
that referenced
this pull request
Aug 26, 2022
`cozy-ui` as been upgraded to to `73.0.1` to retrieve a fix that disable Viewer's download button from cozy/cozy-ui#2215 This commit fixes the previous commit that wrongly set the version 7c6d187 Related PR: #2672 feat: A feat: A
cozy-bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
# [74.4.0](v74.3.0...v74.4.0) (2022-09-06) ### Bug Fixes * Add a mid ellipsis to the filename in the qualification list ([4f30229](4f30229)) * Add a missing `overflow: hidden;` property to the viewer filename ([6d9b5c2](6d9b5c2)) ### Features * Display Viewer's Download button on iOS Flagship app ([b21726c](b21726c)), closes [#2215](#2215)
Merkur39
pushed a commit
to cozy/cozy-libs
that referenced
this pull request
Mar 16, 2023
Merkur39
pushed a commit
to cozy/cozy-libs
that referenced
this pull request
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of iOS Flagship app doesn't handle files
download correctly
So we want to temporarily disable Download button on this platform
This commit is meant to be reverted when files download is fixed on iOS
Flagship app
This commit also refactor margin handling on
FooterContentitemsRelated PRs:
TODO:
Apply breaking change on cozy-mespapiers-lib/SelectFileButton after this PR is mergeddone in feat(mespapiers-lib): Upgrade cozy-ui to 72.0.0 cozy-libs#1808