feat: Do not allow multi accounts features for clientSide konnectors #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our client side konnectors launcher does not handle multiple sessions for the same konnector yet. We choose to deactive multi account feature for client side konnectors at the moment.
Crash--
reviewed
Jan 12, 2022
| @@ -118,7 +118,7 @@ export class AccountModal extends Component { | |||
| return ( | |||
| <> | |||
| <KonnectorModalHeader konnector={konnector}> | |||
| {showAccountSelection ? ( | |||
| {showAccountSelection && !konnector.clientSide ? ( | |||
There was a problem hiding this comment.
Can't we use the showAccountSelection props directly since it already does that same thing?
There was a problem hiding this comment.
Right. Now i define this visibility in the upper level. I removed the unit tests
Crash--
reviewed
Jan 20, 2022
Crash--
approved these changes
Jan 20, 2022
trollepierre
suggested changes
Jan 20, 2022
doubleface
force-pushed
the
feat/HarvestNoMultiAccountClientSide
branch
from
4d429e7 to
72b524d
Compare
trollepierre
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our client side konnectors launcher does not handle multiple
sessions for the same konnector yet.
We choose to deactive multi account feature for client side konnectors
at the moment.
Resolves https://trello.com/c/HoTn7eGr/119-%F0%9F%9A%80%F0%9F%8F%A0-e87-d%C3%A9sactiver-le-multi-compte-sur-les-connecteurs-c%C3%B4t%C3%A9-clients-05-jh