fix: Change timeout to get BI temporary token #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Nov 30, 2021
| @@ -86,7 +87,7 @@ const createTemporaryToken = async ({ client, konnector, account }) => { | |||
| client, | |||
| jobResponse.data.attributes, | |||
| 'result', | |||
| 30 * 1000 | |||
| TEMP_TOKEN_TIMOUT_S * 1000 | |||
There was a problem hiding this comment.
We saw that when BI is long to respond, it takes usually 35s to 40s but
in most cases it takes 2s to 3s.
Why not increasing to 3s instead?
There was a problem hiding this comment.
Dans la plupart des cas, la durée est de 2 à 3 secondes. Mais dans certains cas assez rares (mais difficiles à dénombrer en totalité car plusieurs problèmes provoquent le même symptôme) cela dure plus de 30s et cela abouti à une erreur fatale pour l'utilisateur.
Cela arrive suffisamment pour que des utilisateurs le remontent régulièrement.
Et je préfère mettre limite à 60s au lieu de 33 ou 34 pour avoir de la marge
There was a problem hiding this comment.
Ah oui au temps pour moi, j'ai mal compris. 6*1000 = 60s et pas 6s 😮💨
In some (too many) case, BI can take more than 30s to give response. This leads to timeout error message to the user which occur in their first connection or when renewing their connection. And since these errors occur in the browser, they are not visible in our usual connector error dashboard. We saw that when BI is long to response, it takes usually 35s to 40s but in most cases it takes 2s to 3s
doubleface
force-pushed
the
fix/tempTokenTimout
branch
from
4c14df5 to
f0a0eff
Compare
Crash--
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some (too many) case, BI can take more than 30s to give response.
This leads to timeout error message to the user which occur in their
first connection or when renewing their connection.
And since these errors occur in the browser, they are not visible
in our usual connector error dashboard.
We saw that when BI is long to respond, it takes usually 35s to 40s but
in most cases it takes 2s to 3s.