Add network info in config #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
reviewed
Jan 9, 2025
There was a problem hiding this comment.
I would propose to use the approach of #483 instead of merging this PR.
It is also reasonable to add the network to the config. For the thing you want to achieve here, it seems you rather want to have a network name in the sync specific config object. Having a dictionary to map networks to network names should not happen in the main code. Such stuff needs to handled in the config.
| @@ -54,8 +53,14 @@ async def sync_data_to_db( # pylint: disable=too-many-arguments | |||
| ) | |||
| # we note that the block range computed above is meant to be interpreted as | |||
| # a closed interval | |||
| network_name_map = { | |||
There was a problem hiding this comment.
It seems you you are trying to get to the dune name of networks. This can already be done by using config.dune_config.dune_blockchain. See #483, where the network is not passed and the dune config is used to get the network name.
|
Probably not needed, as explained here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a variable named
networkin the top-level of theAccountingConfig.Addresses comment: #475 (comment)