Skip to content
This repository has been archived by the owner on Nov 2, 2021. It is now read-only.

GitHub logo is not visible #2209

Closed
SwagataJ opened this issue Jul 4, 2020 · 2 comments
Closed

GitHub logo is not visible #2209

SwagataJ opened this issue Jul 4, 2020 · 2 comments
Labels
Status: Review Needed

Comments

@SwagataJ
Copy link

SwagataJ commented Jul 4, 2020

Is your feature request related to a problem? Please describe.
GitHub logo is not visible in both desktops/laptops and mobile devices when using dark theme unless brightness is at maximum.

Describe the solution you'd like
Changing the color of GitHub logo might be considered( A white logo would go with the dark theme but would not work on the original white theme. A halfway happy color has to considered.
@balrajsingh9
Copy link

balrajsingh9 commented Jul 4, 2020 •
edited
Loading

@SwagataJ I have fixed this already in #2180
But my PR is awaiting review, so not sure if the fix in my PR counts. 👀

@SwagataJ
Copy link
Author

SwagataJ commented Jul 5, 2020

Oh! Cool.

@SwagataJ SwagataJ closed this as completed Jul 5, 2020
@balrajsingh9 balrajsingh9 mentioned this issue Jul 15, 2020
Closed
@bijankundu bijankundu mentioned this issue Jul 18, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Review Needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balrajsingh9 @SwagataJ