memory allocation issue in 1.1.0

[OneCyrus]

with the new 1.1.0 version i've a memory allocation issue. i tried it with one of my smaller projects. it generates almost a 10 GB hits-file. and it looks like it would need at least that much memory. currently the system runs out of memory and the dotnet process is stuck while trying to allocate more memory.

[tonerdo]

That's super weird considering some of the changes I did to 1.1.0 was to make Coverlet more memory efficient. I figure there's probably a part of your code that's doing a lot of work that results in lots of writes to the hits file. Is this project open source?

[OneCyrus]

unfortunately it's closed source. yes, it may be due to a lot of looped data processing. 1.0.2 works on this project (though misses some lines as mentioned in other issues). does the hits-file track each hit or only the first time?

[OneCyrus]

i guess replacing ReadAllLines with ReadLines in InstrumentationHelper should fix this.

https://medium.com/@nuno.caneco/c-file-readlines-vs-file-readalllines-4742d738064e

[tonerdo]

All merged in. New release going out on Monday as usual. Thanks

[OneCyrus]

thanks for merging! Will the new release be out soon? We would like to use it in prod.

[tonerdo]

I'm hoping to get a few more fixes in before I do a new release. I'm thinking this Friday, how urgent is your use?

[OneCyrus]

I was just interested to see if this really fixes our problem in prod. no problem, I'll try whenever you're ready with a new release.

[tonerdo]

@OneCyrus new release https://www.nuget.org/packages/coverlet.msbuild/1.2.0