-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage results are incorrect. #18
Comments
@StillLearnin take a look at the actual coverage results file. This could be a bug in just the summary generation |
Here's a sample: For what it's worth, the Actual code being tested:coverage.json relevant portion:
Test with ListAsync() highlighted: |
This doesn't look like much of a #7 issue. I'm thinking it might have something to do with all async methods. |
Not open source but I trimmed the project down to about 1/10th its size and can still reproduce the issue. You can get the trimmed down version here |
I think it may be an issue with timing or memory usage because if you comment out line 16 in Main so as to not seed postal codes, coverlet seems to work. The other option that fixes the issue is to trim down PostalCodesUSA.csv until the total number of lines doesn't exceed ~2000. It doesn't matter which lines you take out, just that the total number of lines is sufficiently small. |
Thanks for providing the repro project. I'll clone it and check things out |
If you could give me some instructions on how to debug this type of project I'd be glad to tackle it. |
@StillLearnin I figured out the problem. The |
I'm gonna look for a more efficient way to write to the hits result file |
I'd be glad to take a look at this and open a pull request |
I have 3 projects and 21 tests all written against
Candle.Services
The text was updated successfully, but these errors were encountered: