Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to ignore deprecated types/methods #175

Closed
safakgur opened this issue Aug 15, 2018 · 3 comments
Closed

An option to ignore deprecated types/methods #175

safakgur opened this issue Aug 15, 2018 · 3 comments

Comments

@safakgur
Copy link

Hi there, amazing project!

I was wondering if you would consider adding an option to ignore types/methods that are marked with ObsoleteAttribute. This way the functionality that is no longer maintained and is already discouraged to use wouldn't affect the coverage results.

@amweiss
Copy link
Contributor

amweiss commented Sep 21, 2018

I was just about to create a pull request to exclude them by default. Always doing it will be a quick change, but you're probably right that an option is a good idea. If I did that, would it be merged?

https://github.com/tonerdo/coverlet/blob/47206b0ec9cf1a561756c441e44b8eeda7d2dace/src/coverlet.core/Instrumentation/Instrumenter.cs#L384 is the easy part from a quick look.

@amweiss
Copy link
Contributor

amweiss commented Sep 21, 2018

See #195

@safakgur
Copy link
Author

#233 and #477 resolved this, thank you @amweiss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants