Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newtonsoft.Json vulnerability to DoS attacks in versions before 13.0.1 #1361

Closed
SiwinskiK opened this issue Jul 11, 2022 · 2 comments
Closed
Labels
Known Issue It's a know issue Priority:0 Critical to the release

Comments

@SiwinskiK
Copy link

Newtonsoft.Json prior to version 13.0.1 is vulnerable to Insecure Defaults due to improper handling of StackOverFlow exception (SOE) whenever nested expressions are being processed. Exploiting this vulnerability results in Denial Of Service (DoS), and it is exploitable when an attacker sends 5 requests that cause SOE in time frame of 5 minutes. This vulnerability affects Internet Information Services (IIS) Applications. The vulnerability is severe and renders coverlet unusable.
Coverlet in version 2.0.9 references an older version of aforementioned library. Upgrade to version Newtonsoft.Json - 13.0.1

@petli
Copy link
Collaborator

petli commented Jul 25, 2022

@SiwinskiK coverlet packages should only be referenced by unit test projects, which generally ought not to be run in IIS, at least not in production. Given that, is this vulnerability still relevant for coverlet? I think, but am not sure, that the older version of Newtonsoft.Json is referenced because of compatiblity with .NET Framework.

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Aug 25, 2022

@petli is true, anyway we're running inside CI so I think that the bump will be good, I don't know but I think that we'll need to bump also the object model used by collectors because test platform already did the bump and so we could break something but it's ok.
We have an open PR #1358 but I didn't had time yet to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Known Issue It's a know issue Priority:0 Critical to the release
Projects
None yet
Development

No branches or pull requests

4 participants