-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CopyCoverletDataCollectorFiles overwrites newer version of NewtonSoft.Json.dll #1226
Comments
Could this be the same issue as discussed in #1045? |
Yes I think it is the same and there are also workarounds. Maybe you can try one of the workarounds there until someone has time to analyze and fix this. |
The issues are the same but the workaround does not work for me. If I don't publish the tests I get the error "Could not find data collector 'XPlat Code Coverage" as explained in this issue #521. |
Hi all! Can someone dogfood this preview version with the fix attempt and tell me if it works? |
When is a new version containing this fix going to be released to Nuget? |
@scnanney can you try the nightly build to confirm that is properly fixed? https://f.feedz.io/marcorossignoli/coverletunofficial/nuget/index.json version 3.1.1-preview.10 |
@MarcoRossignoli I just tried the 3.1.1 preview on our code, and I can confirm that it's now working as expected. |
I recently upgraded my project to .NET 5. When I publish the project I find that the latest version of NewtonSoft.Json.dll 13.0.1 is being overwritten by the version used by coverlet, 9.0.1. The version of Coverlet I'm using is 3.1.0.
If I publish with increased verbosity I can see exactly where the dll is being copied over.
10:6>CopyCoverletDataCollectorFiles:
Copying file from "C:\st.nuget\packages\coverlet.collector\3.1.0\build\netstandard1.0\Newtonsoft.Json.dll" to "C:\src\myProject\Source\Tests\Unit\MyProject.Tests.Unit\bin\Release\net5.0\publish\Newtonsoft.Json.dll".
The text was updated successfully, but these errors were encountered: