-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2
tag doesn't match latest v2.3.0
tag
#222
Comments
Thanks @kurtmckee. We'll get that handled asap. |
The |
@kurtmckee Thanks for the update. I have not been able to reproduce this drift in action version, so I’m missing something. Can you help me with a little more context, such as your CI config for your Coveralls step(s), and your CI build log, at least the portion pertaining to Coveralls? If you could set I’ve added tests to the action now, which you can see in later versions with their results. This is what I will do, but you are welcome to as well: We can start a new PR, replicate your config details in the |
This is what I'm referring to: It is common practice for repos hosting GitHub actions to force major-version git tags (like When This is a significant gap in the release process, and it's what this issue is reporting. |
For example, if you look at the CI workflow in coverallsapp/coverage-reporter, you'll observe this line: - uses: actions/checkout@v4 Then, checking the tags in the actions/checkout repository, you'll see that their I'm requesting that the coverallsapp team continuously update the |
Whoah, I've never seen that before, where a tag/release (for Thank you for the examples and screenshots! Apologies, I think I just wasn't able to "see" that before. I'm relatively new at managing these releases. Let me figure out what went wrong here and how to fix it... |
It's definitely a deviation from the common git practice "immutable repo history" but it's a very specific deviation for GitHub action repos. 👍 |
@kurtmckee this should be fixed. Please let me know if it appears otherwise for you. I don't know how we ended up with a That's the pattern I reimplemented in this repo; although it took a minute since I was being careful, wary to change anything historical that I hadn't done myself nor understood the reasoning for. |
Sure does! Thanks! I don't know if your release process is scripted or documented, but I recommend adding that Thanks for your work on this! 🥳 |
That's a good recommendation. I am just looking for a common pattern to do that. Are you familiar with one? |
I found a good example, so I'm good there! ^^ Thanks for your patience!! |
This should ensure this doesn't happen again: In case it's helpful to anyone with a similar issue, here's a generic workflow to make sure the major version tag (ie. Will work for any major version (
|
Nice! Thank you! |
Please update the
v2
tag in the repo to point to the latest release (v2.3.0
as I write this).It's currently pointing to the previous release SHA.
Thanks!
The text was updated successfully, but these errors were encountered: