Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of empty links from Additional property bagdes #264

Open
pareion opened this issue Sep 18, 2024 · 0 comments
Open

Removal of empty links from Additional property bagdes #264

pareion opened this issue Sep 18, 2024 · 0 comments

Comments

@pareion
Copy link

pareion commented Sep 18, 2024

Hey!

When generating documentation with bagdes and you wanna generate an additional property bagde. It generates it with an empty link(#).

Example:
billede
billede

Schema json:

{
  "$schema": "https://json-schema.org/draft/2019-09/schema",
  "title": "Deployment",
  "type": "object",
  "description": "Deployment enabled or not",
  "properties": {
    "enabled": {
      "type": "boolean",
      "description": "Enable the deployment or not",
      "default": true
    }
  },
  "additionalProperties": false
}

Suggestion to remove the empty link (#) in json_schema_for_humans/md_template.py.
Changing

  • Line 428 and 437 # "Additional Properties of any type are allowed. -> "Additional Properties of any type are allowed.
  • Line 434 # "Additional Properties not allowed. -> "Additional Properties not allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant