Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mlx): add the modeldetailedinfo call #874

Merged
merged 8 commits into from
Oct 15, 2024
Merged

feat(mlx): add the modeldetailedinfo call #874

merged 8 commits into from
Oct 15, 2024

Conversation

paulgerold
Copy link
Contributor

@paulgerold paulgerold commented Oct 10, 2024 •
edited by lprovost-coveo
Loading

Add the model detailed info call :
https://platformdev.cloud.coveo.com/docs/internal?urls.primaryName=Machine%20Learning%20Configuration#/Model%20Detailed%20Info

https://coveord.atlassian.net/wiki/spaces/MLB/pages/4493181070/Model+Information+Page

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@paulgerold paulgerold requested review from a team as code owners October 10, 2024 18:48
@paulgerold paulgerold marked this pull request as draft October 10, 2024 18:50
@paulgerold paulgerold marked this pull request as ready for review October 10, 2024 18:59
gdostie
gdostie reviewed Oct 11, 2024
View reviewed changes
src/resources/MachineLearning/ModelDetailedInfo/details/ModelDetails.ts Show resolved Hide resolved
src/resources/MachineLearning/ModelDetailedInfo/details/ModelDetailsBuildingStats.ts Show resolved Hide resolved
src/resources/MachineLearning/ModelDetailedInfo/details/ModelDetailsCommerceEvents.ts Show resolved Hide resolved
src/resources/MachineLearning/ModelDetailedInfo/details/ModelDetailsLanguages.ts Show resolved Hide resolved
src/resources/MachineLearning/ModelDetailedInfo/details/ModelDetailsStatsPerSource.ts Show resolved Hide resolved
src/resources/MachineLearning/ModelDetailedInfo/details/ModelDetailsSubModels.ts Show resolved Hide resolved
src/resources/MachineLearning/ModelDetailedInfo/ModelDetailedInfo.ts Show resolved Hide resolved
src/resources/MachineLearning/MachineLearning.ts Show resolved Hide resolved
@paulgerold paulgerold added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 584a82d Oct 15, 2024
5 checks passed
@paulgerold paulgerold deleted the MLX-1429-add-the-modeldetailedinfo-call branch October 15, 2024 13:33
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 56.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@LucaCogliandroCoveo LucaCogliandroCoveo LucaCogliandroCoveo approved these changes

@lprovost-coveo lprovost-coveo lprovost-coveo approved these changes

@JTangCoveo JTangCoveo JTangCoveo approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon FelixBlaisThon is a code owner automatically assigned from coveo/frontend-foundation

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paulgerold @gdostie @LucaCogliandroCoveo @lprovost-coveo @JTangCoveo @mtmustapha-coveo