-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lint): migrate to eslint v9 + flat config + recommended rules #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdostie
changed the title
ESlint v9 + Flat config + Recommended rules
refactor: ESLint v9 + Flat config + Recommended rules
Oct 1, 2024
gdostie
force-pushed
the
eslint-v9
branch
2 times, most recently
from
October 1, 2024 18:59
f89629e
to
f0337dd
Compare
BREAKING CHANGE: We updated our config to the recommended typescript-eslint typed rules so some types have become stricter than they were before.
gdostie
requested review from
GermainBergeron,
dmgauthier,
olamothe,
louis-bompart and
alexprudhomme
October 1, 2024 19:06
alexprudhomme
approved these changes
Oct 1, 2024
aperron-coveo
approved these changes
Oct 1, 2024
gdostie
requested review from
FelixBlaisThon
and removed request for
dmgauthier
October 2, 2024 16:26
dmgauthier
reviewed
Oct 3, 2024
dmgauthier
approved these changes
Oct 3, 2024
FelixBlaisThon
approved these changes
Oct 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2024
gdostie
changed the title
refactor: ESLint v9 + Flat config + Recommended rules
fix(lint): migrate to eslint v9 + flat config + recommended rules
Oct 10, 2024
🎉 This PR is included in version 56.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does the following improvements to our ESLint configuration:
lint
orlint:fix
Note to the reviewers for discussion:
any
isn't accepted explicitly as a valid type anymore, so I had to narrow it down to something more meaningful.any
that I simply let it be and disabled the rule, because I don't have enough knowledge of the feature itself to assert the correct type. Perhaps we could let this branch live longer and work on fixing them all before merging? Or merge as is and continue like that.Acceptance Criteria