Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TSP-414): add listByProject endpoint to platform client #858

Merged
merged 10 commits into from
Sep 26, 2024
Merged

feat(TSP-414): add listByProject endpoint to platform client #858

merged 10 commits into from
Sep 26, 2024

Conversation

mtmustapha-coveo
Copy link
Contributor

@mtmustapha-coveo mtmustapha-coveo commented Sep 24, 2024 •
edited
Loading

feat(TSP-414)
Add listByProject endpoint to IPX client.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@alexprudhomme alexprudhomme removed their request for review September 24, 2024 15:23
@mtmustapha-coveo @gdostie
Update src/resources/InProductExperiences/tests/InProductExperiences.…
7564a22 
…spec.ts

Co-authored-by: Gaël Dostie <35579930+gdostie@users.noreply.github.com>
@gdostie gdostie added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit fe32d54 Sep 26, 2024
5 checks passed
@gdostie gdostie deleted the feature/TSP-414-add-list-by-project-endpoint branch September 26, 2024 20:44
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 55.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mtmustapha-coveo added a commit that referenced this pull request Sep 27, 2024
@mtmustapha-coveo
Revert "feat(TSP-414): add listByProject endpoint to platform client (#…
943f8a9 
…858)"

This reverts commit fe32d54.
@mtmustapha-coveo mtmustapha-coveo mentioned this pull request Sep 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
@mtmustapha-coveo
Revert "feat(TSP-414): add listByProject endpoint to platform client" (…
c3650ce 
…#864)

Revert "feat(TSP-414): add listByProject endpoint to platform client (#858)"

This reverts commit fe32d54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdostie gdostie gdostie approved these changes

@aboissinot-coveo aboissinot-coveo aboissinot-coveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/dx

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtmustapha-coveo @gdostie @aboissinot-coveo