Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete update of array object when using updateById #726

Closed
oaikaoz opened this issue Jun 19, 2023 · 6 comments
Closed

incomplete update of array object when using updateById #726

oaikaoz opened this issue Jun 19, 2023 · 6 comments

Comments

@oaikaoz
Copy link

oaikaoz commented Jun 19, 2023

Hello everyone,

I have recently updated the OttomanJS library to version 2.3.3. However, after the update, I noticed a change in the behavior of the data update process. Here is an example:

Initially, my data structure was as follows:

//data current  {address: [{city: "xxx1"}, {city: xxx2}]}


 
 const dataUpdated = await User.updateById(id, {address: [{city: "xxx3"}]});

 console.log(dataUpdated); //  {address: [{city: "xxx3"}, {city: xxx2}]}

When I use the updateById function to update the data as address: [{city: xxx3}], the resulting data from the updateById function still contains two array objects instead of one.

Thank you.

@gsi-alejandro
Copy link
Collaborator

hi @oaikaoz

I was checking and found a bug related to this.

A new fix was implemented and will be released in the next version (soon this week)

thank you for your feedback.

@oaikaoz
Copy link
Author

oaikaoz commented Jul 12, 2023

@gsi-alejandro
That's great, thank you

@oaikaoz
Copy link
Author

oaikaoz commented Jul 22, 2023

hi @oaikaoz

I was checking and found a bug related to this.

A new fix was implemented and will be released in the next version (soon this week)

thank you for your feedback.

hi @gsi-alejandro

May I kindly inquire about the expected release date for the version with the fix

thank you

@ejscribner
Copy link
Collaborator

Hey @oaikaoz, thanks for following up. We will release a new version with the changes early next week (monday or tuesday). Apologies for the delay here, and thank you for your patience 🙂

@oaikaoz
Copy link
Author

oaikaoz commented Aug 1, 2023

Hey @oaikaoz, thanks for following up. We will release a new version with the changes early next week (monday or tuesday). Apologies for the delay here, and thank you for your patience 🙂

hi @ejscribner
thank you

@ejscribner
Copy link
Collaborator

Hey @oaikaoz, we've released v2.3.4 that includes this change. Thanks so much for being a part of the Ottoman community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants