Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default layout should pass lang=lang as parameter to search-loader.html #1582

Closed
1 task done
neilboyd opened this issue Mar 1, 2024 · 2 comments · Fixed by #1583
Closed
1 task done

default layout should pass lang=lang as parameter to search-loader.html #1582

neilboyd opened this issue Mar 1, 2024 · 2 comments · Fixed by #1583
Labels
bug Something isn't working released Included or resolved in the release

Comments

@neilboyd
Copy link
Contributor

neilboyd commented Mar 1, 2024

Checklist

How did you create the site?

Built from jekyll-theme-chirpy

Describe the bug

At the end of default layout is this line:

{% include_cached search-loader.html %}

it should pass in the lang parameter:

{% include_cached search-loader.html lang=lang %}

because it's used inside of search-loader.html to set not_found variable.

Steps To Reproduce

View source - noResultsText is empty:
image

Expected Behavior

noResultsText gets the value from the included language

Environment

  • Ruby: ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux-gnu]
  • Jekyll: jekyll 4.3.3
  • Chirpy: jekyll-theme-chirpy (6.2.3)

I'm using Chirpy 6.2.3, but the bug is still there in latest master

Anything else?

The real reason I want this is because I want to customize search-loader.html and I need lang.

@cotes2020
Copy link
Owner

Thanks for reaching out. Looks like this bug has been around since 61fdbcb.

@cotes2020 cotes2020 moved this to Todo in Chirpy PMS Mar 1, 2024
@cotes2020 cotes2020 linked a pull request Mar 1, 2024 that will close this issue
1 task
@github-project-automation github-project-automation bot moved this from Todo to Done in Chirpy PMS Mar 1, 2024
Copy link

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included or resolved in the release label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Included or resolved in the release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants