Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add idea folder to gitignore #1685

Merged
merged 3 commits into from
Dec 3, 2018
Merged

add idea folder to gitignore #1685

merged 3 commits into from
Dec 3, 2018

Conversation

sabau
Copy link
Contributor

@sabau sabau commented Dec 3, 2018 •
edited by fedekunze
Loading

Closes #ISSUE

Description:

Add .idea to the ignored folders

❤️ Thank you!

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@sabau sabau requested review from faboweb and nylira as code owners December 3, 2018 14:59
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #1685 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1685   +/-   ##
========================================
  Coverage    97.71%   97.71%           
========================================
  Files          101      101           
  Lines         2056     2056           
  Branches        92       92           
========================================
  Hits          2009     2009           
  Misses          36       36           
  Partials        11       11
Impacted Files Coverage Δ
.../renderer/components/governance/PageGovernance.vue 100% <0%> (ø) ⬆️
...pp/src/renderer/components/staking/PageStaking.vue 100% <0%> (ø) ⬆️
app/src/renderer/components/common/TmBalance.vue 100% <0%> (ø) ⬆️

@codecov
Copy link

codecov bot commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #1685 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1685   +/-   ##
========================================
  Coverage    97.71%   97.71%           
========================================
  Files          101      101           
  Lines         2056     2056           
  Branches        92       92           
========================================
  Hits          2009     2009           
  Misses          36       36           
  Partials        11       11

fedekunze
fedekunze approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze merged commit a339600 into develop Dec 3, 2018
@fedekunze fedekunze deleted the sabau/gitignore-update branch December 3, 2018 15:07
This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 14, 2019
Closed
Merged
@faboweb faboweb mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@faboweb faboweb Awaiting requested review from faboweb faboweb is a code owner

@nylira nylira Awaiting requested review from nylira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabau @fedekunze