EPIC: v2.0.0 release

[shaspitz]

Problem

See description from #933

Ie. we need to take all recent features, fixes, and refactors that have accumulated in main and issue a new release.

Closing criteria

Cut a release of ICS with all recent accumulated squash commits in main.

Problem details

Task list

Must have

Preview Give feedback

1. Merge fix!: prevent denom DOS #931
2. Updated changelog in main, incl above
3. Hash out what migrations will be needed to upgrade gaia to this new version of ICS
4. Cut release

Nice to have

Preview Give feedback

No tasks being tracked yet.

[shaspitz]

Per discussion with @mpoke this is now v2 release

[shaspitz]

Hash out what migrations will be needed to upgrade gaia to this new version of ICS

v1.0.0 -> v2.0.0

To be complete, it makes sense to first analyze migrations required between v1.0.0 and v2.0.0 of ICS. The multiden versions aren't too far off the v1.0.0 linage.

I've looked at the diff between main and v1.0.0, along with the PRs included in the changelog from main. Out of the PRs from the v2.0.0 changelog entry, the PRs that should require state migrations are:

• Ser correct byte prefix for SlashLogKey  #786, key prefix was changed
• fix!: prevent denom DOS #931, added params for consumer and provider
• Soft opt out #833, added param for consumer

Note that #963 prevents some key prefix related migrations.

I'd like someone to sanity check my conclusion here. Especially with regard to these PRs, am I missing migrations?:

• Key assignment type safety #725
• feat: standalone to consumer changeover part 1 #757 ← seems ok but worth another look
• Remove spm #812
• Soft opt out #833 ← needs a closer look at possible migrations outside of param addition. Soft opt out threshold param needs to be set before first beginblocker

Multiden versions (running in prod) -> v2.0.0

The migrations required for v1.1.0-multiden and v1.2.0-multiden to v2.0.0 should simply be the migrations required for v1.0.0 -> v2.0.0, minus the migrations of individual squash commits that already exist in each of those versions. I'll add funcs for these into #975

[shaspitz]

Update:

PRs that prevent the need for certain migrations:

• fix!: consumer key prefix order to avoid complex migrations #963 <- prevents key prefix migration on consumers
• fix: partially revert key assignment type safety PR #980 <- prevents cons addr migration on provider

Consumer migrations

With the above PRs merged, it actually seems like the consumer does not require migrations between v1.2.0-multiden and v2.0.0. Reasoning is that the former version includes both 54e9852 and #833, which handle the addition of new consumer params properly.

Provider migrations

#975 has been updated to reflect that the migration of v1.1.0-multiden to v2.0.0 is the same as if migrating from v1.0.0. The migrations needed are:

• One new param added to provider from fix!: prevent denom DOS #931
• Handling the fact that the consumer genesis state schema has changed, ie. we delete the only existing consumer genesis, Neutron
• Handling migrations from this fix, Ser correct byte prefix for SlashLogKey  #786

[shaspitz]

^ it'll be useful to sanity check these conclusions, for now I will open up #975 for review

[shaspitz]

RC is now cut https://github.com/cosmos/interchain-security/releases/tag/v2.0.0-rc1

[mpoke]

https://github.com/cosmos/interchain-security/releases/tag/v2.0.0 is cut.