Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework AfterUnbondingInitiated staking hook on ICS provider #945

Closed
Tracked by #852
MSalopek opened this issue May 11, 2023 · 1 comment · Fixed by #918
Closed
Tracked by #852

Rework AfterUnbondingInitiated staking hook on ICS provider #945

MSalopek opened this issue May 11, 2023 · 1 comment · Fixed by #918
Assignees
@MSalopek
Labels
scope: cosmos-sdk Integration with Cosmos SDK type: refactoring Code refactoring

Comments

@MSalopek
Copy link
Contributor

MSalopek commented May 11, 2023 •
edited
Loading

More context in the cosmos-sdk issue cosmos/cosmos-sdk#16042 and associated PR cosmos/cosmos-sdk#16043

With the new behaviour in cosmos-sdk we need to address the possible panic in provider code then executing the AfterUnbondingInitiated. At present the provider will panic in case the PubUnbondingOnHold operation fails. With changes in cosmos-sdk the panic can be de-escalated into a simple error log since the sdk merges can now merge multiple UndelegationEntries into a single one (provided multiple entries are created for the same height).
@MSalopek MSalopek mentioned this issue May 11, 2023
Closed
9 tasks
@MSalopek MSalopek self-assigned this May 11, 2023
@MSalopek MSalopek added type: tech-debt Slows down development in the long run type: refactoring Code refactoring scope: cosmos-sdk Integration with Cosmos SDK and removed type: tech-debt Slows down development in the long run labels May 11, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub May 11, 2023
@MSalopek MSalopek moved this from 🩹 Triage to 📥 Todo in Cosmos Hub May 11, 2023
@mpoke mpoke mentioned this issue May 16, 2023
Merged
18 tasks
@mpoke mpoke moved this from 📥 Todo to 👀 In review in Cosmos Hub May 16, 2023
@mpoke
Copy link
Contributor

mpoke commented May 16, 2023

This issue is fixed in fa543a8 and is part of #918.

@MSalopek MSalopek linked a pull request May 17, 2023 that will close this issue
feat!: upgrade ics to ibc-go/v7 and cosmos-sdk/v0.47 #918
Merged
18 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub May 22, 2023
@mpoke mpoke mentioned this issue Jul 26, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: cosmos-sdk Integration with Cosmos SDK type: refactoring Code refactoring
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: upgrade ics to ibc-go/v7 and cosmos-sdk/v0.47 cosmos/interchain-security
2 participants
@mpoke @MSalopek