Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inactive Vals: Test rewards in the consumer denom #2128

Closed
p-offtermatt opened this issue Aug 5, 2024 · 1 comment
Closed

Inactive Vals: Test rewards in the consumer denom #2128

p-offtermatt opened this issue Aug 5, 2024 · 1 comment
Labels
more-info-needed Further information is requested scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor 

          "_[...]_ in the consumer chain token" is this actually tested? I only see:

IsNativeDenom: true, // check for rewards in the provider denom
in the tests.

Originally posted by @insumity in #2079 (comment)
@github-project-automation github-project-automation bot moved this to 🩹 F1: Triage in Cosmos Hub Aug 5, 2024
@mpoke mpoke added more-info-needed Further information is requested and removed needs-triage labels Sep 17, 2024
@mpoke mpoke moved this from 🩹 F1: Triage to 📥 F2: Todo in Cosmos Hub Sep 17, 2024
@mpoke mpoke added the scope: testing Code review, testing, making sure the code is following the specification. label Sep 17, 2024
@sainoe
Copy link
Contributor

sainoe commented Oct 15, 2024

Solved by #2290.

@sainoe sainoe closed this as completed Oct 15, 2024
@github-project-automation github-project-automation bot moved this from 📥 F2: Todo to 👍 F4: Assessment in Cosmos Hub Oct 15, 2024
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
more-info-needed Further information is requested scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpoke @sainoe @p-offtermatt