Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor or remove ibc_legacy_testing from ICS #1008

Closed
Tracked by #852
MSalopek opened this issue Jun 12, 2023 · 1 comment · Fixed by #1185
Closed
Tracked by #852

Refactor or remove ibc_legacy_testing from ICS #1008

MSalopek opened this issue Jun 12, 2023 · 1 comment · Fixed by #1185
Assignees
@MSalopek
Labels
scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Jun 12, 2023 •
edited
Loading

legacy_ibc_testing folder contains multiple changes required to run integration and difftesting in ICS.

The name of the folder is a bit misleading. Even though most of the functions in the folder are "legacy" there are useful changes that will need to be kept and ported over to use IBC/v7.
@MSalopek MSalopek mentioned this issue Jun 12, 2023
Closed
9 tasks
@MSalopek MSalopek linked a pull request Jun 12, 2023 that will close this issue
chore: remove legacy_ibc_testing folder #1003
Closed
20 tasks
@MSalopek MSalopek self-assigned this Jun 12, 2023
@MSalopek MSalopek added scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring labels Jun 12, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jun 12, 2023
@MSalopek MSalopek moved this from 🩹 Triage to 🛑 Blocked in Cosmos Hub Jun 14, 2023
@MSalopek
Copy link
Contributor Author

Blocked until v47 is in main and an rc for v3 is cut.

@tbruyelle tbruyelle mentioned this issue Aug 4, 2023
Merged
20 tasks
@mpoke mpoke moved this from 🛑 F3: OnHold to 👀 F3: InReview in Cosmos Hub Sep 4, 2023
@github-project-automation github-project-automation bot moved this from 👀 F3: InReview to 👍 F4: Assessment in Cosmos Hub Sep 7, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: testing Code review, testing, making sure the code is following the specification. type: refactoring Code refactoring
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
1 participant
@MSalopek