From 2ebc0d817fbe4d0195d5dc5e73e53ea115391514 Mon Sep 17 00:00:00 2001 From: Aditya Sripal Date: Thu, 28 Jul 2022 14:50:11 +0200 Subject: [PATCH 1/2] upgrade keys should prefix channel path to standardize key construction --- .../core/ics-004-channel-and-packet-semantics/UPGRADES.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md b/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md index b435bc6e6..81496baf9 100644 --- a/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md +++ b/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md @@ -101,7 +101,7 @@ The upgrade sequence path is a public path that stores the current sequence of t ```typescript function channelUpgradeSequencePath(portIdentifier: Identifier, channelIdentifier: Identifier) Path { - return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeSequence" + return "channelUpgrades/upgradeSequence/ports/{portIdentifier}/channels/{channelIdentifier}" } ``` @@ -129,7 +129,7 @@ The chain must store the previous channel end so that it may restore it if the u ```typescript function channelRestorePath(portIdentifier: Identifier, channelIdentifier: Identifier): Path { - return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/restore" + return "channelUpgrades/restore/ports/{portIdentifier}/channels/{channelIdentifier}" } ``` @@ -139,7 +139,7 @@ The upgrade error path is a public path that can signal an error of the upgrade ```typescript function channelUpgradeErrorPath(portIdentifier: Identifier, channelIdentifier: Identifier): Path { - return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeError" + return "channelUpgrades/upgradeError/ports/{portIdentifier}/channels/{channelIdentifier}" } ``` @@ -182,7 +182,7 @@ The upgrade timeout path is a public path set by the upgrade initiator to determ ```typescript function channelUpgradeTimeoutPath(portIdentifier: Identifier, channelIdentifier: Identifier) Path { - return "channelUpgrades/ports/{portIdentifier}/channels/{channelIdentifier}/upgradeTimeout" + return "channelUpgrades/upgradeTimeout/ports/{portIdentifier}/channels/{channelIdentifier}" } ``` From f18b11637d485df072a5fc1f4efb0ebf12138038 Mon Sep 17 00:00:00 2001 From: Aditya Sripal Date: Thu, 28 Jul 2022 14:59:18 +0200 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5a799ba40..7fde1ffe4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,3 +38,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ # Changelog ## [Unreleased] + +### Improvements + +- [\#807](https://github.com/cosmos/ibc/pull/807) Upgrade keys will now prefix the channel path to align with the rest of ICS4 keys \ No newline at end of file