Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS27: Interchain Accounts allows packets to be received on controller side #603

Closed
colin-axner opened this issue Sep 16, 2021 · 2 comments · Fixed by #845
Closed

ICS27: Interchain Accounts allows packets to be received on controller side #603

colin-axner opened this issue Sep 16, 2021 · 2 comments · Fixed by #845
Assignees
Labels
app Application layer.

Comments

@colin-axner
Copy link
Contributor

Giving the spec a quick glance, I don't see a check enforcing that the receiving port address is the host chain port. This means a malicious ics27 module (host chain) could trick the controller chain into accidentally trying to execute a transaction. I'm not sure if it is exploitable in any way, but there should probably be a check enforcing that controller chain ports cannot receive packets

@mpoke mpoke changed the title Interchain Accounts allows packets to be received on controller side ICS27: Interchain Accounts allows packets to be received on controller side Mar 17, 2022
@mpoke mpoke added the app Application layer. label Mar 17, 2022
@crodriguezvega
Copy link
Contributor

crodriguezvega commented Aug 1, 2022

there should probably be a check enforcing that controller chain ports cannot receive packets

@colin-axner, is then the action for this issue to update the spec to include the same kind of logic that ibc-go has on the OnRecvPacket callback of the controller chain?

@colin-axner
Copy link
Contributor Author

Yes I think so. Will defer to @AdityaSripal on how this should be specified/indicated in the spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Application layer.
Projects
Status: Backlog
Archived in project
3 participants