Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS4: Optimal behaviour for incompatible crossing hello with unequal sequences #1054

Closed
AdityaSripal opened this issue Dec 13, 2023 · 1 comment · Fixed by #1056 or #1055
Closed

ICS4: Optimal behaviour for incompatible crossing hello with unequal sequences #1054

AdityaSripal opened this issue Dec 13, 2023 · 1 comment · Fixed by #1056 or #1055

Comments

@AdityaSripal
Copy link
Member

Currently if there are crossing hellos of incompatible upgrades with unequal sequences.

The TRY will be explicitly rejected on both sides due to an earlier compatibility check before the sequencing logic can write an error receipt.

This then will require an explicit reset by one of the parties to continue the handshake.

One alternative approach could be to instead do the sequencing check first and error out the lower sequence incompatible upgrade.

@sangier
Copy link
Contributor

sangier commented Dec 15, 2023

Thanks for this catch! The alternative approach LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants