Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate mock module into a standalone crate #953

Closed
Tracked by #554
Farhad-Shabani opened this issue Nov 8, 2023 · 0 comments · Fixed by #954
Closed
Tracked by #554

Separate mock module into a standalone crate #953

Farhad-Shabani opened this issue Nov 8, 2023 · 0 comments · Fixed by #954
Assignees
Labels
O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Nov 8, 2023

Overview

As part of our efforts to make ibc-rs more streamlined, enhance usability, and easier to maintain, we are starting by separating the mock module into its own crate. This is a prerequisite step before refactoring our mock testing facilities, which ultimately will improve our testing coverage for ibc-rs and would simplify writing different testing scenarios by host chains.

Proposal

Create a separate crate for the mock module to achieve the following objectives:

  1. Decouple the ibc-rs implementation from testing types and components.
  2. Facilitate refactoring mock implementation so that can have more organized/comprehensive integration tests
  3. Avoid circular dependencies, so would allow importing basecoin-rs libraries.
  4. Make it easy to use the Merkle tree implementation within basecoin-store
  5. Advance the goal of breaking down ibc-rs into smaller, self-contained and modular libraries
@Farhad-Shabani Farhad-Shabani added O: usability Objective: aims to enhance user experience (UX) and streamline product usability O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: decoupling Objective: aims to separate concerns and cause to independent, reusable components labels Nov 8, 2023
@Farhad-Shabani Farhad-Shabani changed the title Separate mocks module into a standalone crate Separate mock module into a standalone crate Nov 8, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Nov 8, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant