Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale encoding for transfer #745

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Jul 4, 2023

Closes: #SELF

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests. (no tests for serde)
  • Linked to GitHub issue (PR is issue).
  • Updated code comments and documentation (e.g., docs/). (no thing to doc)
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (1c5b50b) 72.33% compared to head (ee4371a) 72.28%.

❗ Current head ee4371a differs from pull request most recent head 167c27a. Consider uploading reports for the commit 167c27a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   72.33%   72.28%   -0.05%     
==========================================
  Files         116      116              
  Lines       15529    15539      +10     
==========================================
  Hits        11233    11233              
- Misses       4296     4306      +10     
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/amount.rs 33.33% <0.00%> (-11.12%) ⬇️
crates/ibc/src/applications/transfer/coin.rs 82.19% <0.00%> (-1.15%) ⬇️
...tes/ibc/src/applications/transfer/msgs/transfer.rs 49.51% <0.00%> (-0.99%) ⬇️
crates/ibc/src/applications/transfer/packet.rs 50.00% <0.00%> (-2.39%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review July 9, 2023 09:41
Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty 🙏

@Farhad-Shabani Farhad-Shabani added this to the v0.43.0 milestone Jul 10, 2023
@Farhad-Shabani Farhad-Shabani merged commit e125999 into cosmos:main Jul 10, 2023
10 checks passed
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants