Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS02] [ICS03] Missing ClientType, ClientId validation checks #621

Closed
Tracked by #233
Farhad-Shabani opened this issue Apr 13, 2023 · 2 comments · Fixed by #639
Closed
Tracked by #233

[ICS02] [ICS03] Missing ClientType, ClientId validation checks #621

Farhad-Shabani opened this issue Apr 13, 2023 · 2 comments · Fixed by #639
Assignees
Labels
A: breaking Admin: breaking change that may impact operators A: bug Admin: something isn't working
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Apr 13, 2023

Summary

Part of #233

  • Some IBC messages take in client_state as Any and the correctness of their included ClientType is not checked.
    E.g. client creation handler is missing that.

  • Given that the ClientType is a part of the client identifier constructor, some ClientId checks are missing too.

  • Similar check in IBC-go is carried out by ValidateClientType

@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label Apr 13, 2023
@plafer
Copy link
Contributor

plafer commented Apr 14, 2023

This is called in MsgCreateClient::ValidateBasic(), so IIUC this issue is a subset of (and therefore a duplicate of) #233

@Farhad-Shabani
Copy link
Member Author

This is called in MsgCreateClient::ValidateBasic(), so IIUC this issue is a subset of (and therefore a duplicate of) #233

Regarding #233, we ideally should go through a list of necessary checks and add any missed validation steps by calling/importing relevant ready-to-go functions or error variants. As for the ClientType, There isn't such a callable method. So, even though this issue is implicitly part of that, I wanted first to get on the same page about what a valid ClientType string looks like. Plus, breaking down the changes into smaller, more specific chunks, so we could keep things clearer for the review.

@Farhad-Shabani Farhad-Shabani changed the title [ICS02] [ICS03] Missing ClientType validation [ICS02] [ICS03] Missing ClientType, ClientId validation checks Apr 20, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Apr 20, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.39.0 milestone May 1, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants