Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientState: replace frozen_height() and is_frozen() with confirm_not_frozen() #545

Closed
plafer opened this issue Mar 16, 2023 · 0 comments · Fixed by #531
Closed

ClientState: replace frozen_height() and is_frozen() with confirm_not_frozen() #545

plafer opened this issue Mar 16, 2023 · 0 comments · Fixed by #531
Labels
O: code-hygiene Objective: aims to improve code hygiene O: usability Objective: aims to enhance user experience (UX) and streamline product usability

Comments

@plafer
Copy link
Contributor

plafer commented Mar 16, 2023

frozen_height() and is_frozen() together really serve one purpose: letting the core handlers know if the the client is frozen. We should replace it instead with just one method that does just that:

fn confirm_not_frozen(&self) -> Result<(), ClientError>;
@plafer plafer added O: code-hygiene Objective: aims to improve code hygiene O: usability Objective: aims to enhance user experience (UX) and streamline product usability labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: code-hygiene Objective: aims to improve code hygiene O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant