Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crate] Take consistent approach for handling public structs/fields #532

Open
Tracked by #554
Farhad-Shabani opened this issue Mar 14, 2023 · 0 comments
Open
Tracked by #554

[Crate] Take consistent approach for handling public structs/fields #532

Farhad-Shabani opened this issue Mar 14, 2023 · 0 comments
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding

Comments

@Farhad-Shabani
Copy link
Member

Summary

Part of #25

Take a consistent approach all over the repo at places we have public structs/fields in terms of new instance creation or calling a specific field (e.g. in ics24_host::path)
Should we either have public fields/structs or provide setters/getters/new/default methods (wherever required)?
@Farhad-Shabani Farhad-Shabani added the O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding label Mar 14, 2023
This was referenced Mar 15, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
ibc-rs
Status: 📥 To Do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Farhad-Shabani