Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ibc::handler module #478

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Remove unused ibc::handler module #478

merged 1 commit into from
Feb 28, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Feb 28, 2023

Closes: #XXX

Description

Delete the now-unused ibc::handler module.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Base: 71.30% // Head: 71.52% // Increases project coverage by +0.21% 🎉

Coverage data is based on head (88c7045) compared to base (088861b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   71.30%   71.52%   +0.21%     
==========================================
  Files         126      125       -1     
  Lines       15935    15886      -49     
==========================================
  Hits        11363    11363              
+ Misses       4572     4523      -49     
Impacted Files Coverage Δ
crates/ibc/src/lib.rs 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, seems like we forgot about that one

@plafer plafer merged commit 67c2c46 into cosmos:main Feb 28, 2023
@kevinji kevinji deleted the delete-unused-handler branch February 28, 2023 18:10
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants