Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt send_packet() and send_transfer() API #442

Closed
Tracked by #431
plafer opened this issue Feb 17, 2023 · 0 comments · Fixed by #468
Closed
Tracked by #431

Adapt send_packet() and send_transfer() API #442

plafer opened this issue Feb 17, 2023 · 0 comments · Fixed by #468
Labels
A: breaking Admin: breaking change that may impact operators
Milestone
v0.30.0

Comments

@plafer
Copy link
Contributor

plafer commented Feb 17, 2023 •
edited
Loading

These APIs (and their traits) retain a flavor the old Reader/Keeper API. Changes to make include
(but are not limited to):

  • traits store_* methods should use Path arguments
  • Remove SendPacketResult
  • Probably don't need the Reader/Keeper separation
  • send_{transfer,packet}() should not return a HandlerResult, or use HandlerOutput
    • they should instead use ModuleExtras
  • split into *_validate() and *_execute()
@plafer plafer mentioned this issue Feb 17, 2023
Merged
7 tasks
@plafer plafer changed the title Adapt send_packet() and send_transfer() API to Adapt send_packet() and send_transfer() API Feb 21, 2023
@plafer plafer mentioned this issue Feb 21, 2023
Closed
@plafer plafer added this to the v0.30.0 milestone Feb 23, 2023
@plafer plafer mentioned this issue Feb 24, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Feb 24, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: breaking Admin: breaking change that may impact operators
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.30.0
Development

Successfully merging a pull request may close this issue.

Update send packet/transfer cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani