Update to tendermint 0.26 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
commented
Nov 7, 2022
Comment on lines
+48
to
52
| impl From<ClientTypeAttribute> for abci::EventAttribute { | ||
| fn from(attr: ClientTypeAttribute) -> Self { | ||
| Tag { | ||
| key: CLIENT_TYPE_ATTRIBUTE_KEY.parse().unwrap(), | ||
| value: attr.client_type.to_string().parse().unwrap(), | ||
| } | ||
| (CLIENT_TYPE_ATTRIBUTE_KEY, attr.client_type.as_str()).into() | ||
| } | ||
| } |
There was a problem hiding this comment.
Note that the EventAttribute domain type also has an index field, which is set to false by the From conversion used here.
There was a problem hiding this comment.
Hmm, it may have been too early to switch to tendermint::abci::Event before informalsystems/tendermint-rs#1204 is released. There is still tendermint_rpc::abci::Event confusingly, but it's what hermes is using.
There was a problem hiding this comment.
Upon further examination, the ABCI event infrastructure in Hermes now duplicates this code and is not dependent on ibc. So we can go on with this change.
Option::map_or requires the alternative value to be non-lazily constructed, so we save some allocations.
17 tasks
hu55a1n1
reviewed
Nov 9, 2022
Ramify the name as to_event_attribute_value for clarity.
tendermint-rs is now committed to fully following Rust semver conventions.
hu55a1n1
reviewed
Nov 15, 2022
hu55a1n1
approved these changes
Nov 16, 2022
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Update to tendermint 0.26 * Fix no-std-check with a temporary patch * Post-merge updates for tendermint 0.26 * ics04_channel::events: Use Option::map_or_else Option::map_or requires the alternative value to be non-lazily constructed, so we save some allocations. * Update ibc-proto to 0.22.0 * Rename TimeoutHeight::to_attribute_value Ramify the name as to_event_attribute_value for clarity. * Unpin tendermint version tendermint-rs is now committed to fully following Rust semver conventions. * Convert ClientIdAttribute like the rest of them * Changelog entry for #208 * connection events: remove an outdated comment * Derive derive_more::Into for ClientId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates for tendermint-rs 0.26
Requres changes from cosmos/ibc-proto-rs#31
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.