Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow creation of frozen clients #178

Closed
5 tasks
Tracked by #554
hu55a1n1 opened this issue Oct 13, 2022 · 2 comments · Fixed by #602
Closed
5 tasks
Tracked by #554

Disallow creation of frozen clients #178

hu55a1n1 opened this issue Oct 13, 2022 · 2 comments · Fixed by #602
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@hu55a1n1
Copy link
Contributor

Summary of Bug

We're currently not checking in the create-client handler if the client being created is frozen and I don't think it's in the spec either. Note the spec requires the Tendermint client-state to be initialized with a FrozenHeight: null, but doesn't enforce this in the handler.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1
Copy link
Contributor Author

Related: cosmos/ibc#856

@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Oct 14, 2022
@plafer
Copy link
Contributor

plafer commented Jan 12, 2023

ibc-go doesn't do it either, right?

Then I don't think this is a bug, since our current goal is to be "compliant" to ibc-go 5.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants