Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client- and app-specific error variants from module errors #1348

Open
seanchen1991 opened this issue Sep 19, 2024 · 0 comments
Open
Labels
S: errors Scope: related to error handlings

Comments

@seanchen1991
Copy link
Contributor

Feature Summary

After cleaning up most of the existing String variants from our error types in #1347, there are still a few lingering variants that require some more consideration: ClientError::ClientSpecific and ChannelError::AppSpecific. These two particular variants serve as "backdoors": they allow errors from specific clients (in this case the Tendermint light client) and applications to propagate into the module errors. Ideally, this should not happen.

Proposal

We'll need to come up with a cleaner approach to surfacing client- and application-specific errors, thereby allowing us to remove these backdoor variants from the module errors.

@Farhad-Shabani Farhad-Shabani added the S: errors Scope: related to error handlings label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: errors Scope: related to error handlings
Projects
Status: 📥 To Do
Development

No branches or pull requests

2 participants