Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all conversions that convert from raw and Any types to return DecodingError #1330

Closed
1 task done
seanchen1991 opened this issue Sep 6, 2024 · 0 comments · Fixed by #1350
Closed
1 task done
Labels
S: errors Scope: related to error handlings
Milestone

Comments

@seanchen1991
Copy link
Contributor

seanchen1991 commented Sep 6, 2024

Feature Summary

Currently, many of the TryFrom conversions in ibc-rs return a myriad of error types. With the introduction of the DecodingError type, it makes sense that any conversions that convert from raw types and Any types to domain types should return a DecodingError.

Proposal

  • Migrate all TryFrom impls that convert from a raw type or an Any type to return a DecodingError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: errors Scope: related to error handlings
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants