Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serializers.rs module into ibc-primitives #1055

Closed
Farhad-Shabani opened this issue Jan 24, 2024 · 0 comments · Fixed by #1056
Closed

Move serializers.rs module into ibc-primitives #1055

Farhad-Shabani opened this issue Jan 24, 2024 · 0 comments · Fixed by #1056
Assignees
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

The custom (de)serializer module, initially utilized by the ICS-20 application, is now used by the ICS-721 too, and would serve other IBC applications, such as ICS-27.

Proposal

It is advisable to centralize this module under the ibc-primitives to avoid redundancy and streamline maintenance. This ensures broader reusability, enabling developers of any IBC application built upon the ibc-rs libraries to benefit from.

@Farhad-Shabani Farhad-Shabani added the O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding label Jan 24, 2024
@Farhad-Shabani Farhad-Shabani added this to the 0.50.0 milestone Jan 24, 2024
@Farhad-Shabani Farhad-Shabani self-assigned this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: maintainability Objective: cause to ease modification, fault corrections and improve code understanding
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant