-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pbjson_build
to ensure that proto types have Serialize, Deserialize
impls compatible with ProtoJSON
#95
Comments
It looks like this was done in #92, but not yet released. I see an |
The initial idea was to give @Wizdave97 and others time to make sure that these changes work for them. It then fell under our radar, sorry about that. I think it's indeed time to do a final release now. I'll get on it! |
Amazing, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's useful to be able to serialize and deserialize ProtoJSON. This can only be done together with the proto codegen, not by downstream users, so it happens in the
ibc-proto
crate or not at all.To do it, the
pbjson_build
crate could be hooked into the proto compiler; an example can be found in the Penumbra repo: https://github.com/penumbra-zone/penumbra/blob/main/tools/proto-compiler/src/main.rs#L47 This also involves changing the WKTs to ones that support ProtoJSON, so it's definitely a breaking change.The text was updated successfully, but these errors were encountered: