Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pbjson_build to ensure that proto types have Serialize, Deserialize impls compatible with ProtoJSON #95

Closed
hdevalence opened this issue Apr 27, 2023 · 4 comments

Comments

@hdevalence
Copy link

It's useful to be able to serialize and deserialize ProtoJSON. This can only be done together with the proto codegen, not by downstream users, so it happens in the ibc-proto crate or not at all.

To do it, the pbjson_build crate could be hooked into the proto compiler; an example can be found in the Penumbra repo: https://github.com/penumbra-zone/penumbra/blob/main/tools/proto-compiler/src/main.rs#L47 This also involves changing the WKTs to ones that support ProtoJSON, so it's definitely a breaking change.

@hdevalence
Copy link
Author

It looks like this was done in #92, but not yet released. I see an 0.31.0-alpha.2 tag; is there any reason not to release it as 0.31?

@romac
Copy link
Member

romac commented May 31, 2023

The initial idea was to give @Wizdave97 and others time to make sure that these changes work for them. It then fell under our radar, sorry about that. I think it's indeed time to do a final release now. I'll get on it!

@romac
Copy link
Member

romac commented May 31, 2023

Done in #92 and released in v0.31.0.

@romac romac closed this as completed May 31, 2023
@hdevalence
Copy link
Author

Amazing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants