Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should I abandon cosmos-sdk-proto and point people at ibc-proto instead? #182

Closed
tony-iqlusion opened this issue Jan 19, 2024 · 5 comments
Closed

Comments

@tony-iqlusion
Copy link
Member

The two projects duplicate each others' functionality, but ibc-proto seems more mature at this point.

I find the whole situation a bit confusing and frustrating: ibc-proto has a much bigger scope than just IBC, and is instead a full Cosmos SDK Protobuf library.

cosmos-sdk-proto also has more downloads and a "Used by" count of 661 (whereas that number isn't populated for ibc-proto-rs for whatever reason). Just by virtue of its name it's more discoverable.

But I find duplication of effort to be incredibly demotivating.

@romac
Copy link
Member

romac commented Jan 23, 2024

Hi Tony! Thanks for starting this discussion, I absolutely agree that the current situation is really subpar and we should aim to improve it.

How about I spend some time this week investigating whether we can deduplicate work by:

  • Removing the Cosmos SDK protos from ibc-proto and instead use cosmos-sdk-proto as external definition for those.
  • Removing the IBC protos from cosmos-sdk-proto and advise users to depend explicitly on ibc-proto if they need those

Would that seem like a good course of action to you? Is there something else you think should be done to remediate the current situation?

@tony-iqlusion
Copy link
Member Author

That approach seems fine to me.

I think ideally they'd be in the same repo to synchronize changes, but if that's the direction you'd like to go, I'm happy to work toward that in whatever manner.

@tony-iqlusion
Copy link
Member Author

With #187 open I'll go ahead and close this

@romac
Copy link
Member

romac commented Jan 26, 2024

👍 Shall I open a PR on cosmos-rust so we can discuss there how best to proceed with all this?

@tony-iqlusion
Copy link
Member Author

Yep, absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants